g2c and wgrib2: add [email protected], [email protected] and [email protected], [email protected] #2993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spackbot-triage
bot
added
new-version
dependencies
update-package
conflicts
new-variant
labels
spackbot-triage
bot
requested review from
AlexanderRichert-NOAA,
AlysonStahl-NOAA,
Hang-Lei-NOAA,
edwardhartnett and
t-brown
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/aocc/package.py
repos/spack_repo/builtin/packages/g2c/package.py
repos/spack_repo/builtin/packages/hypre/package.py
repos/spack_repo/builtin/packages/openblas/package.py
repos/spack_repo/builtin/packages/orca/package.py
repos/spack_repo/builtin/packages/umpire/package.py
repos/spack_repo/builtin/packages/w3emc/package.py
repos/spack_repo/builtin/packages/wgrib2/package.py
�[1;34m==> �[0mrunning flake8
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
�[1;34m==> �[0mstyle checks passed
I've updated the branch with style fixes. But it looks like I'm not able to push to your branch. 😭️ Did you check Allow edits from maintainers when you opened the PR? |
AlexanderRichert-NOAA
approved these changes
Jan 9, 2026
climbfuji
approved these changes
Jan 9, 2026
Contributor
|
@AlexanderRichert-NOAA Unfortunately, you need to approve once more after the formatting updates. |
AlexanderRichert-NOAA
approved these changes
Jan 12, 2026
tldahlgren
approved these changes
Jan 14, 2026
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Confirmed the new version sha256s and that new variants are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds versions for
g2candwgrib2packages. Forwgrib2, it also adds a newg2c-related variant, more clearly specifies versioning for theThese package are being used by the spack-stack partners and verified to work.
Notes:
For
wgrib2, also adds:g2c-related variants and a correspondingconflicts()restraintjasperandpngvariantsipis spelled out perREADMEandCMakeLists.txtrequirements detailed in tagged releases in the wgrib2 repository.